Altinity / clickhouse-backup

Tool for easy backup and restore for ClickHouse® using object storage for backup files.
https://altinity.com
Other
1.29k stars 226 forks source link

docs: update clickhouse-backup docker args example #1000

Closed christopherdeutsch closed 2 months ago

christopherdeutsch commented 2 months ago

Hi! I think one of the examples can be simplified.

The current command in the example for clickhouse-backup is

 command:
    - bash
    - -xc
    - "/bin/clickhouse-backup server"

And the Dockerfile ends with:

ENTRYPOINT ["/entrypoint.sh"]
CMD [ "/bin/clickhouse-backup", "--help" ]

This PR will update the docs to just pass server to the entrypoint script, since bash is unnecessary. The -xc flags could be useful for debugging, but I propose that using the args to specify server makes the example more clear.

Slach commented 2 months ago

thanks for contribution

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10720629068

Details


Totals Coverage Status
Change from base Build 10720587739: 65.8%
Covered Lines: 8816
Relevant Lines: 13407

💛 - Coveralls