Closed praveenthuwat closed 4 months ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
pkg/backup/create.go | 2 | 75.58% | ||
pkg/backup/restore.go | 2 | 67.08% | ||
pkg/backup/backuper.go | 2 | 65.12% | ||
cmd/clickhouse-backup/main.go | 2 | 77.19% | ||
pkg/backup/list.go | 2 | 63.44% | ||
pkg/clickhouse/clickhouse.go | 4 | 78.71% | ||
pkg/storage/object_disk/object_disk.go | 5 | 70.95% | ||
pkg/status/status.go | 9 | 70.2% | ||
pkg/config/config.go | 10 | 71.24% | ||
pkg/storage/general.go | 23 | 61.46% | ||
<!-- | Total: | 265 | --> |
Totals | |
---|---|
Change from base Build 9699341182: | -2.0% |
Covered Lines: | 8552 |
Relevant Lines: | 13048 |
thanks for contribution
Hi, If the materialized view names start with a digit and are enclosed in a backtick(`) during the view creation, the regex group capture for matching the TO database is missing. This further leads to the wrong restoration of materialized views, as the TO still points to the source database!
For example:- If we run the following restore command,
clickhouse-backup restore_remote --rm -m default:praveen <backup-name>
The resulting materialized view will be the following. As you can see, the TO is still pointing to the source DB name, i.e.,
default
instead ofpraveen
)The expected one:-