Support TRACE and Flamegraph formats

Altinity / clickhouse-grafana

Altinity Grafana datasource plugin for ClickHouse®

MIT License

713 stars 120 forks source link

Support TRACE and Flamegraph formats #508

Closed Slach closed 4 months ago

Slach commented 7 months ago

Current supported format

Time series
Table
Logs

need to add

Trace format for properly show traceability data system.telemetry_span_log for example
Flamegraph format for properly show flamegraph like pyroscope and tempo

Slach commented 4 months ago

still need some improvements

Slach commented 4 months ago

Just add current implementation details

Format as: Traces

Tracing Example

Format as: Flame Graph

Flame Graph example

Slach commented 4 months ago

@lunaticusgreen what is it bug or expected behavior?

Slach commented 4 months ago

@lunaticusgreen wrong error handling

Slach commented 4 months ago

@lunaticusgreen why so many gray stack traces?

Slach commented 4 months ago

@lunaticusgreen tracing related issue traceID button always copy the same traceID value

but data contains different TraceID (look to after export)

 jq .batches[].instrumentationLibrarySpans[].spans[].traceId "Trace-478cd9-2024-04-22 12_03_45.json" |
 uniq -c | sort
      9 "511ad96f-7da1-85eb-2d99-a5058ca74efc"
      9 "75cbfe3f-5d0a-9683-8f04-4546aca41963"
      9 "81c52f0a-be38-1cd4-7a45-a1654565b72c"
      9 "f5fef918-9d8e-7491-1619-ff8c59478cd9"
     12 "36cbb5d3-0489-703c-94f8-1bcd30fa5d77"
     29 "96f371ea-b61b-7bf3-7773-7b0d6e8f07a7"

Slach commented 4 months ago

@lunaticusgreen could we control deep link behavior? deeplink open explore but query is wrong

maybe we could change something here?