BFF cleanup - Githubissues

Altinn / altinn-access-management-frontend

Frontend for access management

MIT License

3 stars 1 forks source link

BFF cleanup #923

Closed allinox closed 4 months ago

allinox commented 4 months ago

Description

This PR does several types of cleanup pertaining to the BFF:

New naming convention for Controllers and Clients
- Controllers now reflect naming used in react and GUI
- Changes made to react code to usher indicate coming changes where logic and data-mapping will be moved to BFF
- Each external dependency now has a single (aptly named) client
Cleanup in mock data and test files
Fixed so BFF tests now run locally despite new localDev setup

Related Issue(s)

741

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)
[ ] All tests run green

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

sonarcloud[bot] commented 4 months ago

Quality Gate failed

Failed conditions
4.1% Duplication on New Code (required ≤ 3%)
63.1% Condition Coverage on New Code (required ≥ 65%)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint