Generate accesstoken based on keyvault config

Altinn / altinn-accesstoken

Client and server libraries for simple authorization of API calls

BSD 3-Clause "New" or "Revised" License

0 stars 1 forks source link

Generate accesstoken based on keyvault config #15

Closed acn-dgopa closed 9 months ago

acn-dgopa commented 1 year ago

Added extension method to generate access token by fetching certificate from keyvault

Description

Related Issue(s)

{issue number}

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)
[ ] All tests run green

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

acn-dgopa commented 1 year ago

This involves keyvaukt integration and i'm bit confused on what kind of test will be sensible here. Any suggestions?

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication

SandGrainOne commented 9 months ago

The issues I pointed out in my review has not been resolved and the pull request is very old now. Assuming that the feature is unnecessary and that you found an other way to support the use of KeyVault.

The feature request is still registered, so we might return to this at a later time.