Update environments.json

mijohansen commented 1 year ago

This proposition is to remove some complexity in our solutions. Just give the baseurl for the platform and the apps to the consumer. No need to build urls from the parts.

Description

Related Issue(s)

{issue number}

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)
[ ] All tests run green

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

altinnadmin commented 1 year ago

Seems like a "hack"? Repeating hostname a platform prefix, not removing anything, not doing the same for apps. @SandGrainOne what do you think?

SandGrainOne commented 1 year ago

It's a backwards compatible change. It might be possible to clean it up in the future.

ivarne commented 1 year ago

I think it looks good. Hostname just part of the url. I'm working on a suggestion for restructuring config for the new pdf service, and trying to reconstruct the full URL from the hostname is error prone. You need to add information about protocol and port number, and having the freedom to set them individually is a nice feature.

Altinn / altinn-cdn