Altinn / altinn-correspondence

Meldingstjenesten
3 stars 0 forks source link

Scan uploaded attachments #86

Closed Ceredron closed 1 month ago

Ceredron commented 1 month ago

Description

Scan uploaded attachment.

Differs from Broker as it will not need to support >2GB files so we can use a shared storage account with the same Microsoft Defender configuration for all customers.

Related Issue(s)

Verification

Documentation

Andreass2 commented 1 month ago

Code looks good.

But I am thinking we will get the same idempotency problem as we had i broker. Implementing a idempotencyRepository can be done in a seperate issue though

Ceredron commented 1 month ago

Code looks good.

But I am thinking we will get the same idempotency problem as we had i broker. Implementing a idempotencyRepository can be done in a seperate issue though

I have tested it in Azure, and not been able to replicate it. I wonder if the original issue occurred because we had more than one malware scan subscription.

Andreass2 commented 1 month ago

Code looks good. But I am thinking we will get the same idempotency problem as we had i broker. Implementing a idempotencyRepository can be done in a seperate issue though

I have tested it in Azure, and not been able to replicate it. I wonder if the original issue occurred because we had more than one malware scan subscription.

It actually seems Azure Event Grid no longer sends multiple events(they did before). So as long as we can guarantee that we returns a 200 OK in under 30 seconds it should not be a problem