Authorization based filtering of recipients (#472)

[SandGrainOne]

Description

Adding authorization logic to ensure that the recipients of notifications can access the resource they're being notified about.

My own thoughts is that we probably don't need to return a dictionary inside a dictionary. It might be enough with a list as the inner collection. The logic removes all results that are not Permit.

Related Issue(s)

• 472

Verification

• [x] New code builds clean without any errors or warnings
• [x] Relevant automated test added
• [x] All tests run green
• [ ] Manual testing done (required)

Documentation

• [ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

[acn-sbuad]

Placing the logic in the API project makes Core dependent on the Notifications project. I would rather at least the interface be defined in core. The service that will use the authorization is placed in core.

[SandGrainOne]

Placing the logic in the API project makes Core dependent on the Notifications project. I would rather at least the interface be defined in core. The service that will use the authorization is placed in core.

You're right. I forgot to move the interface. I don't want the service logic in Core because it would make Core dependent of PEP. Another idea is to move the logic to Integrations and rename it to "Client". That would isolate the external dependency to a more appropriate library.

[acn-sbuad]

System.InvalidOperationException : Unable to resolve service for type 'Microsoft.AspNetCore.Http.IHttpContextAccessor' while attempting to activate 'Altinn.Common.PEP.Clients.AuthorizationApiClient'.

Getting this error when plugging this code into the new logic in contact point service. Did you experience this when testing locally? Wondering if IHttpContextAccessor should be added to the AddAuthorizationService function.

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud