UnitProfile has a boolean called [UseRegisterForNotification]. We should look into how it should be used or if we need it. Is it in use by Altinn 2. If so, then document the use.
Analysis
Persisted in table: UnitProfile
792236 units in production with this value set to true. ~36% of all units in db
Application logic:
In SBL there are two procedures to update the property UseRegisterForNotification for a UnitProfile within UnitProfileDAL.cs.
This function SaveUnitProfile is again used by UnitProfileSI's method SaveUnitProfileInternal which has 0 references.
The functionn UpdateUnitProfileLastModified is used by UnitProfileSI's method SaveUnitProfile and only updated the property in question if unitProfile.Id == 0.
In SBL I can find two functions that read the property, but as far as I can see the value is not further used in the business logic.
UnitProfileSI.GetIncompleteAndUnconfirmedEntities, returns the list of incomplete units. Property is used to identify the units. Only party Id is returned.
UnitProfileSi.GetUnitProfile returns the unitProfile including property. But property is not used any further. For sub units missing contact details procedure is to then check the main unit.
uses property to determine if unit has incomplete profile
Conclusion
A property we should not migrate. Rules for updating unit profile can be controlled without the property,
There is no logic actually retrieving notification endpoints from Register if property is not set.
This has also been confirmed by Brønnøysundregistrene.
Description
UnitProfile has a boolean called [UseRegisterForNotification]. We should look into how it should be used or if we need it. Is it in use by Altinn 2. If so, then document the use.
Analysis
Persisted in table: UnitProfile 792236 units in production with this value set to true. ~36% of all units in db
Application logic: In SBL there are two procedures to update the property
UseRegisterForNotification
for a UnitProfile within UnitProfileDAL.cs.SaveUnitProfile
is again used by UnitProfileSI's methodSaveUnitProfileInternal
which has 0 references.UpdateUnitProfileLastModified
is used by UnitProfileSI's methodSaveUnitProfile
and only updated the property in question if unitProfile.Id == 0.In SBL I can find two functions that read the property, but as far as I can see the value is not further used in the business logic.
DB logic
Conclusion
A property we should not migrate. Rules for updating unit profile can be controlled without the property, There is no logic actually retrieving notification endpoints from Register if property is not set. This has also been confirmed by Brønnøysundregistrene.