#510 Implementation of adding regression and use case tests that include an app affiliation

[khanrn]

510 Implementation of adding regression and use case tests that include an app affiliation

Description

510 Implementation of adding regression and use case tests that include an app affiliation

Related Issue(s)

• 510

• 507

Verification

• [x] Your code builds clean without any errors or warnings
• [ ] Manual testing done (required)
• [x] Relevant automated test added (if you find this hard, leave it and we'll help out)
• [x] All tests run green

[acn-sbuad]

isn't the same resource used in all environments? Would make more sense to have this as a repo secret rather than an env secret.

[acn-sbuad]

Is it a conscious decision to both org lookup and resource dependency to the existing test case rather than adding a new test with a seperate order request allowing us to validate the sending of an email to a known recipient isolated from sending to org and resource?

[acn-sbuad]

Would be good if we could document the org numbers in pedia along with the other test data.

[khanrn]

isn't the same resource used in all environments? Would make more sense to have this as a repo secret rather than an env secret.

Yes, you are correct! 👍 This is more fit for being a repo secret than an environment variable.

Is it a conscious decision to both org lookup and resource dependency to the existing test case rather than adding a new test with a separate order request allowing us to validate the sending of an email to a known recipient isolated from sending to org and resource?

Yes! It was a conscious decision! Well, although we thought about writing a different test at first, later we agreed to put it together with the existing one as this is a regression test. However, it is definitely worth a consideration again which approach would be better.

Would be good if we could document the org numbers in pedia along with the other test data.

Already started working on it. Trying to find a better way to document it in AltinnPedia. 👍

[khanrn]

@acn-sbuad Here is the doc update: https://github.com/Altinn/altinnpedia/pull/148

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud