547 covers the epic of supporting send conditions in notifications. A part of this is to allow end users to specify the end point to use for checking the send condition when placing an order request.
The scope of this issue is to validate, accept/deny and persist the send condition endpoint along with the notification order.
Consideration
Do we allow any domains to be used as condition endpoint?
All orders are created based on a maskinporten token with a scope only we can delegate, so one should be able to trust the creator of the order
Refinement: We allow any domain.
What do we want to validate except it being a valid url? Do we need to verify that we can reach the endpoint when the order is initially placed?
Refinement: No need for any additional validation.
Tasks
[x] Add conditionEndpoint property as nulleable URL to NotificationOrderRequestBaseExt
[x] Add conditionEndpoint property as nulleable URL to BaseNotificationOrderExt
[x] Add conditionEndpoint property as nulleable URL to NotificationOrderRequest
[x] Add conditionEndpoint property as nulleable URL to IBaseNotificationOrder
[x] Ensure mapping of new property in relevant mappers
[x] Implement required validation in orderRequest validators
[x] QA
[x] Test
[x] Documentation
Tests
Acceptance Criterias
Condition endpoint is persisted to the database is provided in an order request
Condition endpoint is included in output for the basic /order endpoints.
An incomplete url in the condition endpoint property results in a 400 response
Description
547 covers the epic of supporting send conditions in notifications. A part of this is to allow end users to specify the end point to use for checking the send condition when placing an order request.
The scope of this issue is to validate, accept/deny and persist the send condition endpoint along with the notification order.
Consideration
Tasks
conditionEndpoint
property as nulleable URL to NotificationOrderRequestBaseExtconditionEndpoint
property as nulleable URL to BaseNotificationOrderExtconditionEndpoint
property as nulleable URL to NotificationOrderRequestconditionEndpoint
property as nulleable URL to IBaseNotificationOrderTests
Acceptance Criterias