Reject any order with links in texts - Githubissues

Altinn / altinn-notifications

Altinn platform microservice for handling notifications (mail, sms, etc)

MIT License

2 stars 3 forks source link

Reject any order with links in texts #573

Closed tba76 closed 3 months ago

tba76 commented 4 months ago

Description

To prevent any user of notification to send links in notification, any orders with links should be rejected.

Additional Information

@tba76 checks if there are existing libraries to leverage (possibly in use in Altinn studio and in "fluent validation")
Response-code: 400 "Bad request"
Return a problem-detial listing the fields that are invalid
Extend existing validation-pipeline

Tasks

[ ] Development
[ ] Implement unit tests
[ ] QA
[ ] Review documentation to see if updates are required

Acceptance Criterias

[x] An order containing an sms template with a link should result in a 400 response
[x] An order containing an email template with a link should result in a 400 response
[x] An order containing both an email and sms template with links should result in a 400 response.
[x] Encoded links should also result in a 400 response

olebhansen commented 3 months ago

AFAIK, this replicates as-is functionallity.

SandGrainOne commented 3 months ago

Tested and approved.