Altinn / altinn-notifications

Altinn platform microservice for handling notifications (mail, sms, etc)
MIT License
2 stars 3 forks source link

Names lookup in Register that Notifications can use in keyword replacement #593

Open SandGrainOne opened 4 weeks ago

SandGrainOne commented 4 weeks ago

Description

Notifications have a needs for the first, middle and last name of a person as separate properties. The values will be used in search and replace operations when notification texts contains keyword for those values. Register currently doesn't have a suitable endpoint that provide this, so we need to make changes to Register.

This issue will make changes to the register/api/v1/parties/nameslookup endpoint in Register with a new parameter and optionally include the name of a person as separate properties for first, middle and last name.

Additional Information

There was an analysis of existing endpoints in Register: #589. This concluded that we needed changes in Register and potentially in Altinn 2 (bridge). After a talk with the team responsible for Register we've found a solution isolated to Register.

Tasks

Acceptance Criterias

olebhansen commented 3 weeks ago

Checking with Register to get any inputs and/or a go-ahead to do the change and sent a PR.

olebhansen commented 2 weeks ago

OK to submit PR. Check/validate approach with @Alxandr before starting.

olebhansen commented 4 days ago

Input from refinement: v1 can be 1-by-1 lookups