Refactoring and preparing for a review of (more) clean architecture

[hggutvik]

Description

• Renaming IUnitContactPoints -> IUnitContactPointsService
• In IUserProfileService, changing the definition of GetUserListByUuid to return Task<Result<...> like the other interface methods: Related changes:
  • Moving responsibility from the service to the controller, for resolving Result.Error -> empty user profile list
  • Updating references
  • Updating/modifying tests that are impacted by the change
• Fix namespace of Altinn.Profile.Core/ServiceCollectionExtensions
• Other minor refactorings and/or updates, such as simplifying list initializations and correcting outdated README details

Related Issue(s)

• 194

Verification

• [x] Your code builds clean without any errors or warnings
• [ ] Manual testing done (required)
• [x] Relevant automated test added (if you find this hard, leave it and we'll help out)
• [x] All tests run green

Documentation

• [ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[hggutvik]

Manual testing has been performed for most functionality, but I was not able to produce the necessary test data for covering the changes related to units/contactpoints/lookup. This has to be checked in AT/TT envs