Altinn / altinn-studio

Next generation open source Altinn platform and applications.
https://docs.altinn.studio
BSD 3-Clause "New" or "Revised" License
115 stars 70 forks source link

Replace the Dropdown menu in <ExpandablePolicyElement /> with DropdownMenu component from Designsystemet #10869

Open ghost opened 1 year ago

ghost commented 1 year ago

Description

The <DropdownMenu /> component in the <ExpandablePolicyElement /> component is made from scratch rather than using the DropdownMenu component from the Designsystem. This should be replaced once the DropdownMenu component is implemented in the Designsystem. View it on this link.

Additional Information

No response

Tasks

No response

Acceptance Criterias

No response

ghost commented 11 months ago

Blocked by the Z-index bug in the DropdownMenu component from the Designsystem. Issue: https://github.com/digdir/designsystem/issues/1134

framitdavid commented 11 months ago

@WilliamThorenfeldt nice catch! Looks like the design system has fixed this issue now. We just need to wait until next release. 🙌

nkylstad commented 11 months ago

Menu seems to work as expected! Tested OK. EDIT: Found that when clicking "Lag kopi" in the menu, the menu does not close afterwards. New copy is created as expected, but I would expect the menu to close afterwards.

https://github.com/Altinn/altinn-studio/assets/1636323/272b1609-609a-4a5e-8946-205ea1eabd61

There is also no scrolling down to the newly created rule - I have created a new issue for this: https://github.com/Altinn/altinn-studio/issues/11831

ghost commented 9 months ago

Menu seems to work as expected! Tested OK. EDIT: Found that when clicking "Lag kopi" in the menu, the menu does not close afterwards. New copy is created as expected, but I would expect the menu to close afterwards.

Screen.Recording.2023-12-11.at.10.09.17.mov There is also no scrolling down to the newly created rule - I have created a new issue for this: #11831

Thanks for the feedback, and for adding a video! The issue is now fixed in this PR 😄

JamalAlabdullah commented 9 months ago

Tested ok with (closing menu) after clicking on "Lag kopi"