Replace "react-modal" with modal component from Designsystemet once it is ready

ghost commented 7 months ago

nkylstad commented 6 months ago

Modal opens ok, but a few issues:

Select does not seem to work in the modal. Specifically security level select, but tested with a basic select locally and same issue there - seems like the values appear beneath the modal. This issue has also been noticed in production now, ref. https://altinn.slack.com/archives/C02ESDSC929/p1702372499184909
The modal re-sizes with each tab, which causes some annoying movement of the modal. The size of the modal should be fixed.
Probably related to the re-sizing, but there is a double scrollbar in the policy-editor.

nkylstad commented 6 months ago

Ref. this issue - https://github.com/digdir/designsystem/issues/1180. Doesn't seem like we can use the new modal until either the issue is fixed or the new Combobox component is ready

nkylstad commented 6 months ago

Reverted this change for now, need to wait for the above issue to be cleared - we also need to look into how to handle sizing.

framitdavid commented 6 months ago

Reverted this change for now, need to wait for the above issue to be cleared - we also need to look into how to handle sizing.

Suggest we remove this out of sprint and label it with "ready-for-specification", agree? 😊

Altinn / altinn-studio