Altinn / altinn-studio

Next generation open source Altinn platform and applications.
https://docs.altinn.studio
BSD 3-Clause "New" or "Revised" License
111 stars 70 forks source link

Create a unique header #11611

Open mlqn opened 10 months ago

mlqn commented 10 months ago

Description

We currently use two different components for the header (Header.tsx and AltinnHeader.tsx) which leads to visual inconsistencies (e.g different heights, padding, shadow, logo size, menu components, etc).

I suggest merging these two headers into a single, customizable header. This header should be responsive and should work on small screens. We should also consider making it work for unauthenticated users.

We should also replace the <div> tag with the right semantic tag <header>.

Dashboard

dashboard and resourceadm uses Header.tsx

Screenshot-2023-11-16-at-19-02-06

Editor

editor (app-development) and preview uses AltinnHeader.tsx

Screenshot-2023-11-16-at-19-02-19

Additional Information

No response

Tasks

No response

Acceptance Criterias

No response

nkylstad commented 9 months ago

Agreed. The header used on dashboard is the old header, we should implement the new one for dashboard (and anywhere else it is not being used), and make any necessary adjustments.

nkylstad commented 2 months ago

Fixing this should also close https://github.com/Altinn/altinn-studio/issues/12122

Can we move the new header component from app-shared to @studio/components? Check if there are any MUI components/references that can be removed, can we remove the MUI reference entirely some places?

wrt95 commented 2 months ago

Make header like this when screen is small: Image

The Hamburger menu looks like this when clicked: Image

wrt95 commented 1 month ago

The newest picture of how it should look when expanded:

Image

mlqn commented 3 weeks ago

Will the new header also fix these issues?

wrt95 commented 2 weeks ago

Will the new header also fix these issues?

7704 - Yes 😄

Image

11334 - Yes 😄

https://github.com/user-attachments/assets/cb591c9a-20ee-4804-98db-8beea251948c

11798 - Yes 😄