"liste med gyldige verdier" does not delete values correctly.

ghost commented 10 months ago

Description of the bug

If you delete a field that has the same value as another field, all fields with that name are deleted. When you delete a field in between 2 other fields, the names "jump" up.

It also has a validateDOMNesting() error:

After some discussions with UX, the following has been agreed:

Change "Legg til gyldig verdi" with "Legg til ny verdi".
The new value should be an empty string, and not "value".

Steps To Reproduce

https://github.com/Altinn/altinn-studio/assets/133344438/24efef8c-4383-4ecd-860c-980b5166d8b6

https://github.com/Altinn/altinn-studio/assets/133344438/5e93d91c-adf2-4d98-a90a-f65ead2d5919

Additional Information

No response

ghost commented 10 months ago

~~Issue is complete and ready for review. However, it needs the changes from this PR, so the issue is blocked until the PR is merged.~~

JamalAlabdullah commented 9 months ago

I have tested it, It works well, but I see that the button-text still not changed based on what the UX agreed with.

ghost commented 9 months ago

@JamalAlabdullah PR that solves the issue. Great spotted! https://github.com/Altinn/altinn-studio/pull/11879

Altinn / altinn-studio