Altinn / altinn-studio

Next generation open source Altinn platform and applications.
https://docs.altinn.studio
BSD 3-Clause "New" or "Revised" License
114 stars 70 forks source link

Validation error message displayed twice #12082

Closed mlqn closed 3 months ago

mlqn commented 8 months ago

Description of the bug

The error message is displayed twice when trying to clone a repository (MakeCopyModal.tsx) with an invalid name.

I suggest fixing it by removing the second error message. I also suggest validating the text field on the onChange event as we did in the form for creating an app.

Steps To Reproduce

https://github.com/Altinn/altinn-studio/assets/24462611/68b8cad3-86ab-43bd-a672-d1e7fb0c5b6b

Additional Information

No response

nishit-prasad commented 8 months ago

New contributor here: can this be assigned to me, please?

mlqn commented 8 months ago

@nishit-prasad Thanks for wanting to contribute! I've now assigned the issue to you. I've also updated the description to provide more information. If you have any questions or need any help, feel free to reach out.

nishit-prasad commented 8 months ago

@mlqn Thank you! I'm currently getting build errors when running:

docker compose up -d --build

errors:

=> ERROR [designer:bf7d0a759 generate-studio-frontend 6/6] RUN yarn build                                                                                                       163.0s
------
 > [designer:bf7d0a759 generate-studio-frontend 6/6] RUN yarn build:
...
...
failed to solve: rpc error: code = Unknown desc = executor failed running [/bin/sh -c yarn build]: exit code: 1

Trying to resolve this.

mlqn commented 8 months ago

@nishit-prasad This error usually occurs when there is a lack of memory. Can you try increasing Docker resources (memory and CPU)?

Jondyr commented 3 months ago

I believe this might have been solved by 65c603272e5a. @mlqn can you confirm?

mlqn commented 3 months ago

@Jondyr Yes, you're right, I'm closing the issue 👍