Altinn / altinn-studio

Next generation open source Altinn platform and applications.
https://docs.altinn.studio
BSD 3-Clause "New" or "Revised" License
114 stars 70 forks source link

Added selection of data types to sign on the signin task #12869

Closed mlqn closed 3 months ago

mlqn commented 4 months ago

Description

Added the selection of data types to sign on the signin task

https://github.com/Altinn/altinn-studio/assets/24462611/61d2c92e-f6d1-426d-ab51-b191bf5ce40f

Related Issue(s)

Verification

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.09%. Comparing base (5d7be67) to head (d51b5c2). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12869 +/- ## ========================================== + Coverage 91.06% 91.09% +0.03% ========================================== Files 1393 1398 +5 Lines 19732 19794 +62 Branches 2389 2392 +3 ========================================== + Hits 17969 18032 +63 + Misses 1501 1500 -1 Partials 262 262 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ErlingHauan commented 3 months ago

@mlqn tested OK - looks good! 😄 Only thing I noticed was this typo: image

ErlingHauan commented 3 months ago

@mlqn is signatureInformation-OpoX supposed to be shown here? image

wrt95 commented 3 months ago

@mlqn tested OK - looks good! 😄 Only thing I noticed was this typo: image

I noticed that as well. It will be fixed in my upcoming PR 😄

mlqn commented 3 months ago

@mlqn is signatureInformation-OpoX supposed to be shown here? image

@ErlingHauan Nice catch! This will be fixed by this PR, which I just merged