Closed framitdavid closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.06%. Comparing base (
6258b3b
) to head (62b87af
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
A lot of great code! 😄 Added some comments
Thanks! I have answered some of your comments and fixed some! Assigning the review back to you. :)
Description
Continuing cleaning up the process editor to make it more independent of domain knowledge when adding events. When tasks such as payment are added, the app development controls which API calls and side effects should be carried out.
We still need to refine the handling of custom receipts, which will likely need to be changed in a separate PR. But after that, I think we can avoid passing React Query methods down to the process-editor package, which means that we might delete the BpmnApiContext afterwards!
Added skip-releasenotes on this one, since its refactoring only.
Related Issue(s)
Verification