Altinn / altinn-studio

Next generation open source Altinn platform and applications.
https://docs.altinn.studio
BSD 3-Clause "New" or "Revised" License
114 stars 70 forks source link

refactor(ProcessEditor): Decouple integration with BFF when adding tasks in the process editor. #12894

Closed framitdavid closed 4 months ago

framitdavid commented 4 months ago

Description

Continuing cleaning up the process editor to make it more independent of domain knowledge when adding events. When tasks such as payment are added, the app development controls which API calls and side effects should be carried out.

We still need to refine the handling of custom receipts, which will likely need to be changed in a separate PR. But after that, I think we can avoid passing React Query methods down to the process-editor package, which means that we might delete the BpmnApiContext afterwards!

Added skip-releasenotes on this one, since its refactoring only.

Related Issue(s)

Verification

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.06%. Comparing base (6258b3b) to head (62b87af). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12894 +/- ## ========================================== - Coverage 91.07% 91.06% -0.01% ========================================== Files 1396 1393 -3 Lines 19751 19732 -19 Branches 2391 2389 -2 ========================================== - Hits 17988 17969 -19 Misses 1501 1501 Partials 262 262 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

framitdavid commented 4 months ago

A lot of great code! 😄 Added some comments

Thanks! I have answered some of your comments and fixed some! Assigning the review back to you. :)