Open lassopicasso opened 1 month ago
Open question; but do we need two entrances for editing appName
? Could it be sufficient changing it from Settings? Meaning that appName in textResources is updated under the hood when changing name in settings modal, but we do not list the appName from Text-editor?
If so we need to adapt the Settings editor to handle all languages that the app have resource files for. Maybe only by changing the current language from a dropdown next to the appName in the settings modal 🤷♀️
I agree, it is maybe not necessary to handle changes for appName
in both settings and text editor.
I think that sounds like a good solution to use a dropdown in settings to handle other languages as well.
We should discuss this with the team :)
We also need to verify where the app name in applicationMetadata is actually used.
My hypothesis is that it is only used in the inbox. This means that only nb
, nn
and en
languages are relevant.
From refinement:
Only way to update application name should be through settings modal. Updating the application name there should update applicationMetadata.json when relevant (nb
, nn
, en
), and textResource (key: appName
) always.
nb
, nn
, and en
are relevant to update in applicationMetadata. Any other languages supported by the app should only be updated in text resource files.nb
as default. applicationMetadata
and not in the config.json
file in .altinn-studio
folder
Description of the bug
Edit: read the comment from @standeren below.
The
appName
field in the text editor should update thetitle
field inapplicationMetaData
. Currently, this field can only be changed through the settings modal. When the appName is updated in the settings modal, it correctly updates as well theappName
field in the text editor for Bokmål.However, there is a one-way sync issue:
appName
is changed in the text editor, theappName
field in the settings modal (and subsequently in applicationMetaData) is not updated.appName
is changed in the settings modal, it correctly updates the appName field in the text editor for Bokmål (and subsequently in applicationMetaData).Additionally, enabling the text editor to change this field in applicationMetaData should also allow for the inclusion of other languages, such as Nynorsk.
Additionally issue, when changing
title
manually in applicationmetadata - it doesn't update the name in studio because studio read the config file instead of applicationmetadata. As @standeren suggested in the slack thread, maybe change this to only read from metadata instead and get rid of the config file?Steps To Reproduce
appName
is updatedAdditional Information
Should add some playwright tests for this :)
Slack: https://altinndevops.slack.com/archives/CDU1S3NLW/p1717492210499339
No response