Altinn / altinn-studio

Next generation open source Altinn platform and applications.
https://docs.altinn.studio
BSD 3-Clause "New" or "Revised" License
114 stars 70 forks source link

12576 when component is deleted ensure to remove all configuration for the deleted component #12940

Closed standeren closed 3 months ago

standeren commented 3 months ago

Description

To Consideration

Current solution when a component is deleted is to replace the reference with null when it behaved as a value, or remove it if it behaved as a member of an array. Not sure if replacing the value with null is the best solution. May be better to delete the object? However, that will not work for expressions. Might check with Apps what makes most sense for Studio to do. Either way we are going to make illegal config or config that will not run correct (or as intended) in an app.

Verification

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 99.07407% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.48%. Comparing base (396c405) to head (f71a6a8). Report is 4 commits behind head on main.

Files Patch % Lines
frontend/app-development/router/routes.tsx 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12940 +/- ## ========================================== + Coverage 91.46% 91.48% +0.01% ========================================== Files 1400 1405 +5 Lines 19821 19873 +52 Branches 2395 2400 +5 ========================================== + Hits 18130 18180 +50 - Misses 1427 1428 +1 - Partials 264 265 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.