12634 implement validation across layouts when loading layout set with modal warning user of the issue

Altinn / altinn-studio

Next generation open source Altinn platform and applications.

https://docs.altinn.studio

BSD 3-Clause "New" or "Revised" License

109 stars 73 forks source link

12634 implement validation across layouts when loading layout set with modal warning user of the issue #12988

Closed JamalAlabdullah closed 5 days ago

JamalAlabdullah commented 1 week ago

Description

Added validation to check if there are duplicated IDs across layouts.
Added a new component for a modal that shows the warning message in case there is duplication.
Added related tests.

Related Issue(s)

12634

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.80%. Comparing base (d2e9f4e) to head (05cfb6a). Report is 4 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #12988 +/- ## ========================================== + Coverage 91.78% 91.80% +0.01% ========================================== Files 1400 1402 +2 Lines 19827 19859 +32 Branches 2388 2390 +2 ========================================== + Hits 18199 18231 +32 Misses 1371 1371 Partials 257 257 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ErlingHauan commented 1 week ago

One more thing: Can you make the components with the duplicate IDs display the red/danger color, as shown here?

Annikenkbrathen commented 1 week ago

One more thing: Can you make the components with the duplicate IDs display the red/danger color, as shown here?

We worked on a similar design on the issue @lassopicasso worked on. I agree that we should mark the accordion that contains this conflict red. And if possible, mark the relevant components red aswell. In Lars's issue we decided to add a red background to the config that contains errors. So for now, maybe just add a red bakcround on the component (without spending time on making the icon and the red stroke) until we design the error pattern for Studio in general.

And use the error validation from the designs system on the datamodel config

https://storybook.designsystemet.no/?path=/story/komponenter-nativeselect--error

And double-check that you have the same red color