prevented overflow in expression

JamalAlabdullah commented 6 days ago

Description

Updated css in LogicalExpressionEditorand StudioCodeFagmentcomponents to avoid overflow with a long text.

Related Issue(s)

12970

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.49%. Comparing base (fe90360) to head (d9da04b). Report is 27 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #13014 +/- ## ======================================= Coverage 91.49% 91.49% ======================================= Files 1406 1406 Lines 19895 19895 Branches 2403 2403 ======================================= Hits 18202 18202 Misses 1428 1428 Partials 265 265 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JamalAlabdullah commented 2 days ago

Here is the solution for long text id overflow, there is just one thing changed, which is deletebutton for id , it is now under the id and takes the full width i hope it is ok to be like that @Annikenkbrathen ?🤔

https://github.com/Altinn/altinn-studio/assets/90609090/6a1cd6ce-db76-4afe-bcd3-44405e5aaab1

Annikenkbrathen commented 2 days ago

Here is the solution for long text id overflow, there is just one thing changed, which is deletebutton for id , it is now under the id and takes the full width i hope it is ok to be like that @Annikenkbrathen ?🤔

Spiller-overvfllow.mp4

I have some feedback in general. I do not know it this is in the scope of this issue.

The delete button is for deleting the whole expression rule, not just the id. So it should be connected to the frame so the users understand what the button is for. Could it be placed in the frame, in the top right corner above the id? Today we have everything in this frame. Why is the frame gone in this video?
The select for choosing datamodel has a white background. Why is that? can the background be removed so its similar to the other components?

The whole editor needs som design improvements to match the rest of the studio components, but that could be fixed in a new issue after I am done with this https://github.com/Altinn/altinn-studio/issues/12627 . I created an issue for design improvements https://github.com/Altinn/altinn-studio/issues/13045

Altinn / altinn-studio