Altinn / altinn-studio

Next generation open source Altinn platform and applications.
https://docs.altinn.studio
BSD 3-Clause "New" or "Revised" License
115 stars 70 forks source link

feat: remove creat subfom buttom and show delete button just when it is a sā€¦ #14053

Closed JamalAlabdullah closed 1 day ago

JamalAlabdullah commented 1 week ago

Description

Like this:

https://github.com/user-attachments/assets/13299879-ef03-4256-be72-2d86b779b469

Related Issue(s)

Verification

Documentation

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.32%. Comparing base (eb8f613) to head (0ada1ed). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #14053 +/- ## ========================================== - Coverage 95.32% 95.32% -0.01% ========================================== Files 1775 1773 -2 Lines 23128 23097 -31 Branches 2685 2683 -2 ========================================== - Hits 22047 22017 -30 + Misses 833 832 -1 Partials 248 248 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


šŸšØ Try these New Features:

JamalAlabdullah commented 5 days ago

Great work @JamalAlabdullah šŸ’Ŗ šŸ™‚

I have some separated comments. And according to the video, can you fix so that the height will stay the same when delete button is displayed or not? šŸ™‚

And there are some text resources that are no longer in use after you removed CreateSubformWrapper - remove them as well. Just control that they are not used somewhere else.

Good catch šŸ‘ I fixed the height and removed unused texts.