search

Altinn / altinn-studio

Next generation open source Altinn platform and applications.
https://docs.altinn.studio
BSD 3-Clause "New" or "Revised" License
111 stars 70 forks source link

Update design of inbox elements #5495

Open Febakke opened 3 years ago

Febakke commented 3 years ago

Description

Our apps do not support all the features an Altinn 2 elements does. This makes the expanded element look buggy and off. Skjermbilde 2021-01-14 kl 08 31 48

The design in the inbox is ment for Altinn 2 elements with more text and features, our elements do not seem to fit.

Note: Sub-status will add a description text to the element.

Screenshots

Screenshots or links to Figma (make sure your sketch is public)

Considerations

This suggestion by @altinnadmin should be taken into consideration (From: #5494)

Would it be better to have a standard way of handling messages

Currently the inbox is based on the very limited service types in Altinn 2, something that makes it difficult to handle the flexibility of apps in Altinn 3 in the inbox. An app is not always a message, or a form. It can be whatever.

Could we instead go the other way and simplify? For apps, just use the service owner logo as icon instead of the envelope and pencil, and just "Åpne" instead of "Gå til skjemautfylling" etc. That way we avoid these strange cases and all the related complexity.

Acceptance criteria

Describe criteria here (i.e. What is allowed/not allowed (negative tesing), validations, error messages and warnings etc.)

Specification tasks

Development tasks

Add tasks here

Definition of done

Verify that this issue meets DoD (Only for project members) before closing.

OlaStalberg commented 3 years ago

We have an application that serves as a notice to the receivers. This notice has alot of information and attachments. There is also a possibility for the receiver to fill in a form in the application. Our application contains 2 steps:

  1. Information about the notice to the receiver and a button to lead you to the form
  2. The form

The message in the Altinn-inbox contains one button with a referral to "signing a form" or "Gå til skjemautfylling" in norwegian. That does not match with our first step in our application which is not a form, but information about the notice. We dont want combine the information and attachments with the form. It should have its own step.

Please consider a solution where we can provide the information and attachments contained in the message in the Altinn-inbox. That way the button could lead directly to the form when and if the receiver finds it necessary to fill it. Another option would be to be able to change the button text to something more suitable as suggested in https://github.com/Altinn/altinn-studio/issues/5494#issuecomment-784979541

nkylstad commented 9 months ago

@Febakke What is the status of this issue?

Febakke commented 9 months ago

Maybe @sorensensig and "arbeidsflate" should talk to Altinn 3/apps at some point to look into this. I still think one of the main entryways into the apps is an important aspect of the UX on apps developed on our platform. But I dont think Studio should hold this one. I say close this and I can nudge Sigurd if he dont see this mention.

altinnadmin commented 9 months ago

Also see this comment https://github.com/Altinn/altinn-studio/issues/5494#issuecomment-1864027347

This issue basically boils down to if it's ok for Studio as a product to have potential misleading buttons for apps in Altinn inbox until it is replaced by Dialogporten.

sorensensig commented 8 months ago

Maybe @sorensensig and "arbeidsflate" should talk to Altinn 3/apps at some point to look into this. I still think one of the main entryways into the apps is an important aspect of the UX on apps developed on our platform. But I dont think Studio should hold this one. I say close this and I can nudge Sigurd if he dont see this mention.

Forwarding this mention to @indiamaydesign as I unable to tag Mette (product owner arbeidsflate) here. Can you bring this up with Mette and team arbeidsflate India?

elsand commented 8 months ago

Also see this comment #5494 (comment)

This issue basically boils down to if it's ok for Studio as a product to have potential misleading buttons for apps in Altinn inbox until it is replaced by Dialogporten.

Agreed. Also, see my https://github.com/Altinn/altinn-studio/issues/5494#issuecomment-1876790047

nkylstad commented 5 months ago

@altinnadmin who exactly is responsible for making changes to altinn 2 inbox for altinn 3 elements? Has that responsibility been delegated to a specific team? This issue has been stuck way back in the backlog for years, so I'm questioning whether it's worth it to spend time on it at this stage. Your suggestion in https://github.com/Altinn/altinn-studio/issues/5494#issuecomment-1864027347 seems to be a quite simple fix though, but then we need to determine who gets to do it 😅

altinnadmin commented 5 months ago

who exactly is responsible for making changes to altinn 2 inbox for altinn 3 elements

@nkylstad In reality, Studio is the only product in Altinn 3 that has elements displayed in Altinn 2 inbox, and there are no other teams feeling this pain.

If the pain is large enough, and the fix simple enough, I'd create a PR with the text fix in Azure DevOps, and check with @borresundberg when the next deploy of Altinn II is planned. Perhaps somebody in team-fa has a development image up and running so they quickly can test the PR?