Making node-lookups faster

[olemartinorg]

Description

This should make node-lookups faster. Previously, every page would be iterated to look for a node object, but as node-ids can no longer be duplicated/re-used across pages, we can just create a Map to look them up directly. This also has the advantage of running getBaseComponentId() 0 or 1 times, instead of once-per-page for pages that don't have the node in them.

I also removed some unused code in node traversal.

Related Issue(s)

• 2699

• 2688

Verification/QA

• Manual functionality testing
  • [ ] I have tested these changes manually
  • [ ] Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
  • [x] No testing done/necessary
• Automated tests
  • [ ] Unit test(s) have been added/updated
  • [ ] Cypress E2E test(s) have been added/updated
  • [x] No automatic tests are needed here (no functional changes/additions)
  • [ ] I want someone to help me make some tests
• UU/WCAG (follow these guidelines until we have our own)
  • [ ] I have tested with a screen reader/keyboard navigation/automated wcag validator
  • [x] No testing done/necessary (no DOM/visual changes)
  • [ ] I want someone to help me perform accessibility testing
• User documentation @ altinn-studio-docs
  • [ ] Has been added/updated
  • [x] No functionality has been changed/added, so no documentation is needed
  • [ ] I will do that later/have created an issue
• Support in Altinn Studio
  • [ ] Issue(s) created for support in Studio
  • [x] This change/feature does not require any changes to Altinn Studio
• Sprint board
  • [ ] The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
  • [ ] I don't have permissions to do that, please help me out
• Labels
  • [x] I have added a kind/* label to this PR for proper release notes grouping
  • [ ] I don't have permissions to add labels, please help me out

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud