Altinn / app-frontend-react

Altinn application React frontend
BSD 3-Clause "New" or "Revised" License
18 stars 31 forks source link

Binary attachment upload: Thumbnails for the attachments uploaded in SBL #792

Open Febakke opened 5 years ago

Febakke commented 5 years ago

Functional architect/designer: @-mention Technical architect: @-mention

Description Should there be thumbnails for the attachments uploaded with the Binary attachment upload?

The Binary attachment component is handled in issue Altinn/altinn-studio#769 (Altinn Studio view) and Altinn/altinn-studio#291 (SBL)

Sketch (if relevant) (Screenshot and link to Figma, make sure your sketch is public!)

Navigation from/to (if relevant) This functionality is reached from...

Technical considerations Input (beyond tasks) on how the user story should be solved can be put here.

Acceptance criterea

Tasks

olemartinorg commented 1 year ago

Not quite sure what SBL is, but I'm assuming it refers to app-frontend (from context). Meaning, this issue is for showing thumbnails of attachments in app-frontend. While that's entirely possible, it is a lot more difficult than it might appear on the surface.

A few bunch of questions from me:

In summary, I don't think this is worth it from a security perspective. With great risks, we'd need to implement this carefully, and such a job would probably cost more than the reward is worth.

bjosttveit commented 1 year ago

In https://github.com/Altinn/app-frontend-react/pull/1199 different icons were added for some different file types. I agree with @olemartinorg that thumbnails are more complicated than they may be worth, so maybe we should consider just adding an icon that indicates an image file type instead?