Altinn / app-lib-dotnet

Libraries used in Altinn Apps
BSD 3-Clause "New" or "Revised" License
8 stars 11 forks source link

Include KeyVault as configuration source by default #702

Open RonnyB71 opened 4 months ago

RonnyB71 commented 4 months ago

Description

In order to use keyvault you first need to enable support for keyvault in the applicatio ref https://docs.altinn.studio//nb/altinn-studio/reference/configuration/secrets/. This makes the connection string to keyvault available. Then you can use the ISecretsClient or other implementations to manually connect to keyvault to get specified secrets, certificates or keys.

What we would like is to have keyvault enabled by default and as a configuration source so that you can automatically populate IOptions<> implementations as any other configuration and inject this into your code.

Additional Information

Some application owners have allready enabled keyvault as a configuration source. When we do this by default this might be breaking existing applications which means that we should do this in next major release and potentially include migration code to ease the migration for service owners.

Tasks

No response

Acceptance Criterias

bjorntore commented 1 month ago

Just a note: We added a helper method for adding KV as a config source a few months back, to make it a bit simpler to setup payment etc.