search

Altinn / app-localtest

Solution for testing apps locally on your own machine
8 stars 14 forks source link

Missing implementation of LocalTest.Services.Storage.Implementation #4

Open HenningNormann opened 3 years ago

HenningNormann commented 3 years ago

Is your feature request related to a problem? Please describe

In OED we need to look up instances. Most of the methods in LocalTest.Services.Storage.Implementation are not implemented (throws NotImplementedException) - including all methods to search for instances.

Another problem is that the HomeController.GetTestOrgToken doesn't support setting read/write scopes need use APIs above.

Describe the solution you'd like

Implement the not implemented methods mentioned above, and add support for setting read/write scopes in GetTestOrgToken.

Describe alternatives you've considered

Additional context

altinnadmin commented 3 years ago

Will be handled by Altinn/altinn-storage#127, see first "main problem".

acn-sbuad commented 3 years ago

@altinnadmin It would be a quick win to implement the missing methods. I don't think this should be put on hold because of future support of multiple Storage backends. @HenningNormann a seperate issue should be created for the issues with scopes in localtest so they can be prioritized individually.

altinnadmin commented 3 years ago

@acn-sbuad Are you sure? If what Henning is writing is correct, it is most methods?

Most of the methods in LocalTest.Services.Storage.Implementation are not implemented (throws NotImplementedException) - including all methods to search for instances.

SandGrainOne commented 2 years ago

I created an issue covering one of the methods some time ago: https://github.com/Altinn/app-localtest/issues/30