search

Altinn / app-template-dotnet

Altinn Studio application template
1 stars 8 forks source link

New app repository contains JWTValidationCert.cer file #158

Closed acn-sbuad closed 1 year ago

acn-sbuad commented 2 years ago

Description

The file JWTValidationCert.cer is included in the App folder for a new application. Cannot see how this is a required file in the app template.

To Reproduce

Expected behavior

This file should not be a part of the app template.

Screenshots

Additional info

nkylstad commented 1 year ago

@RonnyB71 Any idea what this file is?

ivarne commented 1 year ago

It's a certificate that is used to verify JWT tokens. Seems to be the same used in Localtest, and it looks like the corresponding private key is availibe there jwtselfsignedcert.pfx.

I always assumed that it was a cert that would be used in apps to validate tokens form LocalTest. As far as I can see, it is never referenced in app templates, but instead it is fetched from an opeinId jwks endpoint. I think the cert is safe to remove from the app template (along with the instructions to copy it into the deplyoment package).

RonnyB71 commented 1 year ago

@tjololo you deleted this file - right? Can we close this issue?

ivarne commented 1 year ago

It appeared in a test app from a week ago https://altinn.studio/repos/xivne/test1/src/branch/master/App/JWTValidationCert.cer

It appears to be in the Altinn Studio repo. https://github.com/Altinn/altinn-studio/tree/master/src/studio/AppTemplates/AspNet/App Not sure about the details, of where the moving process is.

nkylstad commented 1 year ago

Yep, looks like it's still in the Studio copy of the template. Once we can start using the new solution of fetching app template directly from app-template-dotnet this will be solved. We have a PR for that ready which is blocked, pending a new release of app-template-dotnet @RonnyB71 @tjololo

tjololo commented 1 year ago

Not removed in the altin-studio copy, but we plan to release a new version of app-template later today/early tomorrow. Then the PR in studio is unblocked and we can close this issue

nkylstad commented 1 year ago

Fetching app template from app-template repo is merged to master. This will be fixed in studio prod when we deploy.