Remove link to altinn-din from app-template - Githubissues

Altinn / app-template-dotnet

Altinn Studio application template

BSD 3-Clause "New" or "Revised" License

2 stars 8 forks source link

Remove link to altinn-din from app-template #184

Closed tjololo closed 1 year ago

tjololo commented 1 year ago

Description

In the next release of app-frontend, the font is switched to use Inter, and this font is added directly through app-frontend's css bundle, so a link in app-template is not needed https://github.com/Altinn/app-frontend-react/pull/1173. Therefore, the link to Altinn-DIN should be removed since this will no longer be used.

Related Issue(s)

Fixes #181

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)
[ ] All tests run green

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

bjosttveit commented 1 year ago

FYI: the switch to Inter is not in prod yet

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

tjololo commented 1 year ago

Setting @bjosttveit as reviewer, he can approve this when the necessary changes in app-frontend is in prod

RonnyB71 commented 1 year ago

Setting @bjosttveit as reviewer, he can approve this when the necessary changes in app-frontend is in prod

Missed the comment and approved, but still valid as I'm just a poor backender :-D