search

Altinn / app-template-dotnet

Altinn Studio application template
1 stars 8 forks source link

Revert "Remove link to altinn-din from app-template" #188

Closed tjololo closed 8 months ago

tjololo commented 1 year ago

Change of font caused breaking changes. Reverting removal of altinn-din

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ivarne commented 9 months ago

5 months? Should this be done in all apps created in that timeframe too?

tjololo commented 9 months ago

5 months? Should this be done in all apps created in that timeframe too?

There has not been any releases of the template so no apps are affected by the removal

olemartinorg commented 8 months ago

@bjosttveit Do we need this, or can we load the font CSS via app-frontend?

bjosttveit commented 8 months ago

@bjosttveit Do we need this, or can we load the font CSS via app-frontend?

I would much rather have app-frontend be in control of the font, and we simply need to switch the css import from inter to altinn-din (it has its own css file with font-face definitions) and then switch the font-family. That way we wont have apps loading unecessary assets when we eventually switch to something else.

image
tjololo commented 8 months ago

Removing it is fine by me, does version 3 of app-frontend load the font? We can remove it again when we upgrade the tempate to version 4 if version 3 doesn't manage it by it self

bjosttveit commented 8 months ago

Right, v3 does not currently load the font itself, and still relies on this being set in the template

bjosttveit commented 8 months ago

I created a branch for changes related to frontend v4 here