search

Altius / hotspot2

Implementation of hotspot2 by Eric Rynes
16 stars 3 forks source link

hotspot2.cpp erroneously calls SiteManager::getFDRvalsAndWriteAndFlush at end of BackgroundRegionManager::computePandFlush() #7

Closed erynes closed 8 years ago

erynes commented 8 years ago

BackgroundRegionManager::computePandFlush() is erroneously calling SiteManager::getFDRvalsAndWriteAndFlush() at the end. This causes erroneous termination of hotspot2 with an error message when there are some valid sites followed by a large gap of unmappable territory near the start of chr1 (or near the start of any chromosome when hotspot2 is run in parallel on one chromosome at a time). Simple fix: This call needs to be moved to the end of parseAndProcessInput().

While at it, PvalueManager::computeFDRvals() is erroneously getting called twice every time SiteManager::getFDRvalsAndWriteAndFlush() is getting called. The direct calls were moved inside SiteManager::getFDRvalsAndWriteAndFlush(), and should've been deleted at that time.

erynes commented 8 years ago

Closed by erynes via 6e5ba85e5bed35204c22039d1b44e39939f1aed0.