AltraMayor / f3

F3 - Fight Flash Fraud
https://fight-flash-fraud.readthedocs.io/en/stable/
GNU General Public License v3.0
2.52k stars 141 forks source link

Better explanation of meaning corrupted and changed #210

Open axet opened 1 year ago

axet commented 1 year ago

Can man page explain better (in technical terms) what corrupted and changed means?

I found some explanation on stackexchange:

But I feel it is lacking core part about how f3write works and it should explain algorithm how it writes the data.

I can understand when CPU send wrong data, or when data stored incorrectly. Would be nice instead "Slightly changed" it could use common term like CRC error. Or corrupted like BUS transfer error (or END to END error like in SMART terminology)

EDIT: I had to check source code and find out this is all nonsense. Here is no END to END error checks. No way this is should be in the code. Basically here is no difference between changed / corrupted. Simple CRC errors:

        else if (error_count <= TOLERANCE)
            stats->secs_changed++;
        else
            stats->secs_corrupted++;
AltraMayor commented 1 year ago

Stephen Kitt's answer on StackExchange is perfect.

I'm adding the label "Help Wanted" to see if someone step up to write a pull request to improve the documentation.