search

AltraMayor / gatekeeper

The first open-source DDoS protection system
https://github.com/AltraMayor/gatekeeper/wiki
GNU General Public License v3.0
1.33k stars 229 forks source link

Remove all rte_panic() calls #572

Open AltraMayor opened 2 years ago

AltraMayor commented 2 years ago

Gatekeeper deployers have been increasing their reliance on Gatekeeper and Grantor servers. And, in these production environments, turning a disruptive failure into a graceful failure is a justifiable effort given the stakes. While moving toward higher standards is going to be a common theme in the evolution of Gatekeeper, it's certainly time to remove all rte_panic() calls present in the code.

AltraMayor commented 2 years ago

The new log entries associated with this issue should likely have the log level CRIT or higher.

AltraMayor commented 2 years ago

RTE_VERIFY() should also be eliminated from the code since it works similarly to rte_panic().

There may be a few spots in the code where printing the call stack would help diagnose the problems that rte_panic() and RTE_VERIFY() were there to catch. More information on printing the call stack at the man page backtrace(3).