search

AltspaceVR / AltspaceSDK

Software Development Kit for AltspaceVR
https://developer.altvr.com/
MIT License
161 stars 73 forks source link

Merging gamejam branch #105

Closed amberroy closed 8 years ago

amberroy commented 8 years ago

Adding ownership feature to Object3DSync behavior, enabled by keeping track of clientIds in SceneSync.

GavanWilhite commented 8 years ago

(hey, dunno if this is finished or not, but looks like the elemental docs are still there, will want to re run doc gen)

On Tue, Feb 2, 2016 at 2:14 PM Amber Roy notifications@github.com wrote:

Adding ownership feature to Object3DSync behavior, enabled by keeping

track of clientIds in SceneSync.

You can view, comment on, or merge this pull request online at:

https://github.com/AltspaceVR/AltspaceSDK/pull/105 Commit Summary

  • initial version
  • ownership and better logging
  • elemental
  • ownership changes
  • Merge branch 'feature/elemental' into feature/gamejam
  • Untested masterClient. isOwner -> isMine. Behaviors are ok with changes to hierarchy during behavior updates.
  • Sorted out event handler order. Added automatic ownership on instantiate
  • Updating spinning-cube to new Object3DSync
  • make a childRef specifically for the color
  • Merge pull request #96 from AltspaceVR/feature/gamejam-spinning-cube
  • Upgrade drag and gamepad behaviors to use ownership
  • Upgrade chess and hats example to use ownership
  • Merge pull request #97 from AltspaceVR/feature/gamejam-upgrade-behaviors
  • Merge branch 'feature/gamejam' into feature/gamejam-upgrade-examples
  • Merge pull request #99 from AltspaceVR/feature/gamejam-upgrade-examples
  • uncommented local feedback block on sync
  • Remove Elemental.js behavior, fix masterClientId
  • Added sceneSync.clientsRef
  • Comment out references to Elemental behavior
  • Merging changes to README

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/AltspaceVR/AltspaceSDK/pull/105.

amberroy commented 8 years ago

Good catch, I'd forgotten to run doc gen, done now.

GavanWilhite commented 8 years ago

Great, it's a little hard to see in the change log here, but were you able to look at the documentation comments from Brian?

amberroy commented 8 years ago

Added doc comments from Brian in PR https://github.com/AltspaceVR/AltspaceSDK/pull/102

brianpeiris commented 8 years ago

Avoid including generated docs in pull requests, it makes them impossible to review. The deploy script will take care of generating docs for releases going forward.

amberroy commented 8 years ago

Done, thanks for you feedback! Re Object.keys ordering, I had the same question and looked it up, yes it will preserve insertion order for strings, which is not technically a standard but is the "de factor" standard on all browsers including Chrome. In any case our code does not rely on a specific order, because although the master client is usually the one who's been in the room longest, we don't guarantee it (only that there will be exactly 1 master client per room).