search

AlttiRi / twitter-click-and-save

[userscript] Adds buttons to save images and videos in Twitter, also does some other enhancements. (Twitter image and video downloader)
https://greasyfork.org/en/scripts/430132
GNU General Public License v3.0
105 stars 11 forks source link

Error When Downloading Gif/Videos #34

Open DReaper opened 1 year ago

DReaper commented 1 year ago

When I attempt to save a gif/video, a Gray error box appears. I was able to download a while ago.

I can download images with no issues.

AlttiRi commented 1 year ago

Do you use FF + VM?

Seems, it's an issue with Violentmonkey / Firefox: https://github.com/violentmonkey/violentmonkey/issues/1895

AlttiRi commented 1 year ago

BTW, I see, that the current API calls do not work for anonymous users. I need to use some other API to add the support to non-logged-in users will be able to download videos.

AlttiRi commented 1 year ago

I fixed the bug with VM + FF https://github.com/AlttiRi/twitter-click-and-save/commit/1195481330e996b942ae025407d7a7b538566d78.

It was appeared from this commit: https://github.com/AlttiRi/twitter-click-and-save/commit/d74e7c2d3138fe4b8da46a97c5c24fa2b7be71a0. It was unexpected that the simplesearchParams.keys method may not work in FF's content script context.

AlttiRi commented 1 year ago

Well, Elon Musk have returned the ability to use Twitter without requirement to be logged-in. I will check how to download the videos in this case later.

DReaper commented 1 year ago

Looks like the update fixed it! Much appreciated for the fast response.

Erfaniom commented 3 months ago

my script has also started to do this, when i click the button it instantly turns into error

AlttiRi commented 3 months ago

my script has also started to do this, when i click the button it instantly turns into error

Are you logged in? Currently, the video download does not work only if you do not log in to your Twitter account.

Also, if you use Firefox + ViolentMonkey you may need to enable "Strict Tracking Protection Fix" in the settings popup. https://github.com/AlttiRi/twitter-click-and-save?tab=readme-ov-file#if-the-script-does-not-work