AltynbekKZ / galleriffic

Automatically exported from code.google.com/p/galleriffic
0 stars 1 forks source link

Fix for IE8 max-width bug #124

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?

1. Placing attributes max-width and max-height in  
  div.slideshow a.advance-link img {}
(That is, controlling the maximum size of the image.  Probably same issue with 
min-width and min-height; probably same fix.

What is the expected output? What do you see instead?

Should see images restricted to the dimensions indicated, PRESERVING ASPECT 
RATIO.  This is seen in all browsers except IE8 (and IE6, but that's a 
different problem).  

In IE8, both max's are applied, which may change aspect ratio (squashed image).

What version of the product are you using? On what operating system?
galleriffic 2.0.2  

This is a known IE8 bug for dynamic images.

FIX:
In galleriffic.js, immediately following line 630 (ie, just above 
newSlide.find('a') ), insert two lines:

  imageData.image.removeAttribute('width');  
  imageData.image.removeAttribute('height'); 

Please provide any additional information below.

This has no effect (as far as I've seen) in any other browser.

I found this idea at http://nfine.net/bugs/ie8bug.html

I would suggest this be included in the next release of galleriffic.

Kim Kirkpatrick

Original issue reported on code.google.com by kirk...@gmail.com on 15 Jun 2010 at 10:50

GoogleCodeExporter commented 8 years ago
Thanks a lot for this tip!

I was checked all the internet to find this type of solution.

Thanks, thanks, thanks

Original comment by Castanet...@gmail.com on 3 Dec 2011 at 3:08