AltynbekKZ / galleriffic

Automatically exported from code.google.com/p/galleriffic
0 stars 1 forks source link

Double clicking images #95

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. visit the 'Minimalist' example
2. double-click on the main image, two images appear (Safari 4)
3. double-click it again; each time, an additional image is added.

What is the expected output? What do you see instead?
during the slide transition, I would expect the 'buildImage' method to lock.

What version of the product are you using? On what operating system?
Downloaded 3/21/2010, Mac OS X, Safari

Please provide any additional information below.
I added a temporary bandaid:
        //remove old stuff
        this.$imageContainer.empty();
        // Construct new hidden span for the image
         var newSlide = this.$imageContainer
            .append('<span class="image-wrapper current"><a class="advance-link" rel="history" 
href="#'+this.data[nextIndex].hash+'" 
title="'+imageData.title+'">&nbsp;</a></span>')
            .find('span.current').css('opacity', '0');

Original issue reported on code.google.com by coli...@gmail.com on 21 Mar 2010 at 10:40

GoogleCodeExporter commented 8 years ago
I have noticed this same bug in Firefox with the most recent 2008 copyright 
version
of gallerific. Colinta can you document where you applied the bandaid you made? 
Thanks. 

Original comment by jamesmeh...@gmail.com on 5 Apr 2010 at 5:51

GoogleCodeExporter commented 8 years ago
james,

Add:
this.$imageContainer.empty();

Below:
 var nextIndex = this.getNextIndex(imageData.index);

Original comment by jomar...@gmail.com on 16 Apr 2010 at 8:50

GoogleCodeExporter commented 8 years ago
this works great... but the caption container still gets multiple instances 
when double 
clicking on the thumbs

Original comment by emanuel....@gmail.com on 16 Apr 2010 at 12:53

GoogleCodeExporter commented 8 years ago
Add:

this.$captionContainer.empty();

After:

var newCaption = 0;

Original comment by EDOm...@gmail.com on 16 Apr 2010 at 11:47

GoogleCodeExporter commented 8 years ago
the code that jomargon posted is the same fix that I applied.  in my source 
file, this is at line 630.

Original comment by coli...@gmail.com on 16 Apr 2010 at 11:54

GoogleCodeExporter commented 8 years ago
@EDOmlid: works perfect now. Thanks guys!

Original comment by emanuel....@gmail.com on 19 Apr 2010 at 7:41

GoogleCodeExporter commented 8 years ago
Guys you made my day, thanks!

Original comment by CamilloM...@gmail.com on 5 May 2010 at 5:51

GoogleCodeExporter commented 8 years ago
Thanks guys!

Original comment by ric...@gmail.com on 26 May 2010 at 3:21

GoogleCodeExporter commented 8 years ago
Thanks a lot! Needed a while until I found out, it is not my mistake...

Original comment by johannes...@gmail.com on 26 Sep 2010 at 1:47

GoogleCodeExporter commented 8 years ago
thanks a lot guys

Original comment by aneeshbh...@gmail.com on 2 Nov 2010 at 8:48

GoogleCodeExporter commented 8 years ago
Thanks for your effords, but the bugfix posted by EDOmlid on Apr 16, 2010 make 
me loose the counter "photo-index" (Example 5). What I did is following (I need 
no fading effects on captions):

- Bugfix by jomargon, Apr 16, 2010
- Modyfying HTML-Code:
  Old: <div id="caption"><div class="photo-index"></div></div>
  New: <div id="caption"><div class="photo-index"></div><span class="current"></span></div>
- Putting a block into Comments:
 /*
  if (this.$captionContainer) {
    previousCaption = this.$captionContainer.find('span.current').addClass('previous').removeClass('current');              }
*/
- Replacing:
  Old: newCaption = this.$captionContainer.append('<span class="image-caption current"></span>').find('span.current').css('opacity', '0').append(imageData.caption);
New: newCaption = 
this.$captionContainer.find('span.current').html(imageData.caption);

Seems to do what it should do.

Greetings,

Markus

Original comment by vdv8...@uni-muenster.de on 4 Nov 2010 at 12:06

GoogleCodeExporter commented 8 years ago
@EDOmlid

Hi,

Being new to Javascript I'm not entirely sure where I should place this code?

Any help would be appreciated. 

Cheers.

Tom

Original comment by hancock...@gmail.com on 7 Dec 2010 at 11:14

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
You can also add "overflow: hidden;" to the css for your slideshow container div

Original comment by dylan.va...@gmail.com on 8 Jun 2011 at 5:33

GoogleCodeExporter commented 8 years ago
The combination of the two replacements below did the trick for me. Thanks guys!

Add:
this.$imageContainer.empty();

Below:
 var nextIndex = this.getNextIndex(imageData.index);

and

Add:
this.$captionContainer.empty();

Below:
var newCaption = 0;

Original comment by overw...@gmail.com on 28 Jul 2011 at 5:18

GoogleCodeExporter commented 8 years ago
Thanks for the fix Overw. It worked like charm. I'm curious as to how you 
figured the fix out?

Original comment by ryanfar...@gmail.com on 23 Sep 2011 at 9:56

GoogleCodeExporter commented 8 years ago
Thanks for taking the time to post this fix. Worked for me.

Original comment by bvansl...@gmail.com on 7 Oct 2011 at 6:28

GoogleCodeExporter commented 8 years ago
Duplicate of issue #75

Original comment by i...@bitfire.at on 15 Mar 2012 at 11:59

GoogleCodeExporter commented 8 years ago
just so you guys know... if you don't have captions showing, don't add

this.$captionContainer.empty();

to the script.

I did that (I don't have captions) and the div that was holding my "slides / 
images" was blank.  When I only used the first revision, which is the following 
line... 

this.$imageContainer.empty();

it seemed to work fine, and IS working fine now... no more crazy double images!

Everytime you double click it, the images just continue to multiply down the 
page.  It's awful, and a very lousy part of this gallery.  Although overall, 
this gallery is just what I was looking for.  

Thanks to those helping out here, who are much smarter than I am with 
JavaScript.

Original comment by irahende...@gmail.com on 28 Jun 2012 at 4:06

GoogleCodeExporter commented 8 years ago
Thanks a lot guys !!!
I thinks it should be fixed in the next version.
So that no one will suffer with this one in the future.

Original comment by ros...@vouny.com on 5 Jan 2013 at 7:43