AltynbekKZ / galleriffic

Automatically exported from code.google.com/p/galleriffic
0 stars 1 forks source link

Cannot append with insertMethod #96

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Put 1 picture
2. call insertImage with position 1
3. Fail

What is the expected output? What do you see instead?
It would be nice to have the possibility to append a picture with the
insertImage function

What version of the product are you using? On what operating system?
Last

Please provide any additional information below.

Hi dude, nice plugin ;)

However, I think you can enhance the code @jquery.gallerific.js@function
addImage.
You are confused between the parameters insert and position in the case of
appending.

Why having two functions appendImage and insertImage? And not just one
insertImage with a optional parameter position. No position would mean
appending (you already do the test line 162). However, currently, the
function insertImage used as append does not work because you manage badly
these 2 variables (insert and position).

Greg

Original issue reported on code.google.com by gberger....@gmail.com on 2 Apr 2010 at 1:20