search

Alua-Kinzhebayeva / iOS-PDF-Reader

PDF Reader for iOS written in Swift
MIT License
532 stars 150 forks source link

Newer version required Swift 5 #117

Open msaqlainbhatti opened 2 years ago

msaqlainbhatti commented 2 years ago

installing the pod from the repo, first build always ask few changes to newer version Files PDFPageView Line 90 & 107 to contentView.sendSubviewToBack(backgroundImageView) decelerationRate = UIScrollView.DecelerationRate.fast

Similarly PDFViewController Line 119 public var scrollDirection: UICollectionView.ScrollDirection = .horizontal {

Please review and update the following line of code for newer versions of swift lang,

msaqlainbhatti commented 2 years ago

FROM: 90 contentView.sendSubview(toBack: backgroundImageView) TO: 90 contentView.sendSubviewToBack(backgroundImageView) Error: 'sendSubview(toBack:)' has been renamed to 'sendSubviewToBack(_:)' FROM: 107. decelerationRate = UIScrollViewDecelerationRateFast TO: 107. decelerationRate = UIScrollView.DecelerationRate.fast Error : 'UIScrollViewDecelerationRateFast' has been renamed to 'UIScrollView.DecelerationRate.fast'

FROM: 119. public var scrollDirection: UICollectionViewScrollDirection = .horizontal { TO: 119. public var scrollDirection: UICollectionView.ScrollDirection = .horizontal { Error: 'UICollectionViewScrollDirection' has been renamed to 'UICollectionView.ScrollDirection'

msaqlainbhatti commented 2 years ago

bitrise is not building thew build

periva101 commented 1 year ago

yes please