search

Alua-Kinzhebayeva / iOS-PDF-Reader

PDF Reader for iOS written in Swift
MIT License
533 stars 150 forks source link

Added background color customization #26

Closed bruno-rocha-movile closed 7 years ago

bruno-rocha-movile commented 7 years ago

While the PDF pages fill the iPad screens nicely, the user is greeted with an ugly, black background on iPhone ones. I took the liberty of changing the default background to a gray-ish color, and added an instance method to allow users to provide their own BG colors.

bruno-rocha-movile commented 7 years ago

Thank you, I am still using 2.3, so I was not on par with some of the naming conventions.

jwelton commented 7 years ago

👍 I think thats a good solution @bruno-rocha-movile

bruno-rocha-movile commented 7 years ago

My last changes made it crash, hold on

bruno-rocha-movile commented 7 years ago

Alright, should be good now (we now need the optional unwrapping because the user might set this before pushing the viewController)

ranunez commented 7 years ago

This is a great improvement! Thanks @bruno-rocha-movile and @jwelton !!