dh_Lain.fx & dh_rtgi.fx compile errors

[ghost]

Hi - your repo was recently added to the ReShade Installer for people to download. That's great, but with that, we've noticed more users reporting that two of your shaders, dh_Lain.fx and dh_rtgi.fx are not compiling successfully.

Here is my log ran, and the compile errors I have recieved.

18:19:07:233 [01176] | ERROR | Failed to compile "C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\reshade-shaders\Shaders\DH\dh_Lain.fx":
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000028FCD1C8EE0(109,16-37): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000028FCD1C8EE0(118,15-40): warning X3556: integer divides may be much slower, try using uints if possible.
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000028FCD1C8EE0(143,22-92): warning X3570: gradient instruction used in a loop with varying iteration, attempting to unroll the loop
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000028FCD1C8EE0(137,6-17): error X3511: unable to unroll loop, loop does not appear to terminate in a timely manner (1024 iterations)
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000028FCD1C8EE0(127,4-15): error X3511: forced to unroll loop, but unrolling failed.

18:19:07:412 [01176] | ERROR | Failed to compile "C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\reshade-shaders\Shaders\DH\dh_rtgi.fx":
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000028F4F2E1F80(1326,2): warning X4000: use of potentially uninitialized variable (outColor)
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000028F4F2E1F80(1326,2): warning X4000: use of potentially uninitialized variable (outAO)
error X8000: Validation Error: source component 0 in temp r3 not initialized. Opcode #25 (count is 1-based)
error X8000: Validation Error: source component 1 in temp r3 not initialized. Opcode #25 (count is 1-based)
error X8000: Validation Error: source component 2 in temp r3 not initialized. Opcode #25 (count is 1-based)
error X8000: Validation Error: source component 3 in temp r3 not initialized. Opcode #25 (count is 1-based)
error X8000: Validation Error: source component 0 in temp r4 not initialized. Opcode #26 (count is 1-based)
error X8000: Validation Error: source component 1 in temp r4 not initialized. Opcode #26 (count is 1-based)
error X8000: Validation Error: source component 2 in temp r4 not initialized. Opcode #26 (count is 1-based)
error X8000: Validation Error: source component 3 in temp r4 not initialized. Opcode #26 (count is 1-based)

[AlucardDH]

Great news! I wasn't aware of that. Thanks for the logs, I'll take a look. Could you, please, tell me which renderer TLAO uses ?

[AlucardDH]

@Jorbann I hopefully fixed both. Can you confirm ?

[ghost]

Sorry for the late reply!

TLOU uses DX12!

Both do compile on DX12 - so this is a success! However, both shaders are still providing a heap of warnings, they are likely not important (as the shaders are working,) but still worth noting.

C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000011962DD73C0(904,13-20): warning X3578: Output value 'outColor' is not completely initialized
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000011962DD73C0(905,13-18): warning X3578: Output value 'outHit' is not completely initialized
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000011962DD73C0(921,15-25): warning X3556: integer modulus may be much slower, try using uints if possible.
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000011962DD73C0(923,15-24): warning X3556: integer modulus may be much slower, try using uints if possible.
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000011962DD73C0(380,14-34): warning X3556: integer modulus may be much slower, try using uints if possible.
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000011962DD73C0(644,19-52): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000011962DD73C0(864,7): warning X4000: use of potentially uninitialized variable (F__DHRTGI__trace)
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000011962DD73C0(869,6): warning X4000: use of potentially uninitialized variable (F__DHRTGI__trace)
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000011962DD73C0(747,4): warning X4000: use of potentially uninitialized variable (F__DHRTGI__trace)
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000011962DD73C0(1641,17-35): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000011962DD73C0(1652,17-43): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000011962DD73C0(1655,17-42): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000011962DD73C0(1704,17-35): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them

C:\Program Files (x86)\Steam\steamapps\common\The Last of Us Part I\Shader@0x0000011910C11160(127,15-40): warning X3556: integer divides may be much slower, try using uints if possible.

[gabriele2000]

DX9 isn't compiling, there's something about float4 to float3 conversion or something, if you want I can post the error message.