search

Aluerie / HextechButEfficient

🔠League of Legends tool for quick & efficient management of some chores (list in README)
MIT License
8 stars 1 forks source link

[BUG] Skin Collection Stats throws `KeyError: 910001` on run #3

Closed BlossomiShymae closed 11 months ago

BlossomiShymae commented 11 months ago

Describe the bug

The application fails to run Skin Collection Stats with KeyError: 910001.

To Reproduce

Open the application and run Skin Collection Stats.

Expected behavior

Expected to get stats for skin collection.

Console

HextechButEfficient Console
13:09:18 | Skin Collection Stats |  Starting
13:09:18 | Skin Collection Stats |  Failed with exception. Contact developers about it:
KeyError: 910001

Desktop

Additional context

910001 seems to be the skin ID for Winterblessed Hwei.

Aluerie commented 11 months ago

Thanks, somewhat fixed it in just released 0.4.0 version.

I'm using https://cdn.merakianalytics.com/riot/lol/resources/latest/en-US/champions.json to get skin prices, but unfortunately they indeed haven't added Hwei yet. But for example, Winterblessed Camille and other new skins are present in the json.

It's not allowed to get store related data from the user's league client directly - not allowed as in by rioters, so I have to rely on known public cdns. so I guess gotta wait for meraki to update their stuff.

As a workaround - added price category 'Unknown' that will be shown in the table with a list of those skins if such problem occurs. Not sure if I can think of a better solution for this.

image