search

Alujjdnd / Ngrok-LAN

A FabricMC mod that exposes your local LAN server to the internet with Ngrok.
MIT License
31 stars 8 forks source link

[INCOMPATIBILITY] Custom LAN #29

Open Sirmentio opened 1 year ago

Sirmentio commented 1 year ago

Name of Mod Custom LAN

Link to Mod Source https://github.com/DimiDimit/Custom-LAN

Screenshots N/A

Desktop (please complete the following information):

Additional context

Flooflez commented 1 year ago

I can see this being fixable, but I'm not exactly sure how.

This might take some time to fix because I'm a little busy at the moment and Custom LAN entirely overhauls how LAN worlds work.

Our mod just takes the Vanilla way and tunnels it with ngrok. I would have to define different behaviour when Custom LAN is being used. This will take some time to figure out how to make them compatible.

slovinsqui commented 1 year ago

please do, custom LAN is the only way I can use simple voice chat without buying a server

DimiDimit commented 8 months ago

Seeing as this mod reimplements a lot of Custom LAN's features, it'll probably be easier to just add ngrok support to Custom LAN…

For the time being, you could use the CLI (replace 25565 with your port):

ngrok tcp 25565

See also https://github.com/DimiDimit/Custom-LAN/issues/28.

Flooflez commented 8 months ago

@DimiDimit You totally can go ahead if you wish, I don't really have the time to work on this project these days.

Here's the wrapper we're using, it's pretty simple to use. You can use this project for reference if needed/

DimiDimit commented 8 months ago

ngrok support has been added in Custom LAN 2.3.0, using the new Tunnel button on the Open to LAN screen! As a bonus, you can start and stop the tunnel without restarting the LAN server and kicking all players out.

Flooflez commented 8 months ago

@DimiDimit cool man, I've added a won'tfix tag to this