Alvearie / alvearie-helm

repository for the helm chart source and package for Alvearie projects
https://artifacthub.io/packages/helm/linuxforhealth
Apache License 2.0
3 stars 5 forks source link

[FHIR] add readinessProbe to deployment.yaml #13

Closed michaelwschroeder closed 3 years ago

michaelwschroeder commented 3 years ago

We need to add a readinessProbe which calls $healthcheck using exec vs. http since we need to grab the user password from an environment variable.

lmsurpre commented 3 years ago

If we needed just the env var's value we could use the kubernetes support for env var interpolation via $( ). Unfortunately, we're trying to use it within an HTTP readiness probe and that doesn't support basic auth except for setting the Authentication header yourself. So we'd actually need to be able to base64 encode the username:password and there is no way to do that from an HTTP readiness probe without writing that password (albeit encoded) right into the deployment yaml.

Instead, the password should be kept in a secret (already done now), and we should use curl to invoke the endpoint.