search

Alvearie / alvearie-helm

repository for the helm chart source and package for Alvearie projects
https://artifacthub.io/packages/helm/linuxforhealth
Apache License 2.0
3 stars 5 forks source link

Allow pathtype and http port #64

Closed ranum closed 2 years ago

ranum commented 2 years ago

Signed-off-by: David Ranum dlranum@us.ibm.com

ranum commented 2 years ago

This PR has two small modifications. First it allows for the inclusion of a pathType so that we can create "ImplementationSpecific" ingress paths using regex. Second, it allows the exposedHttpEndpoint to have a configured port, different from the default 9080 so that we can use the cluster based default communication (on port 80) instead of specifying the port in each.

lmsurpre commented 2 years ago

It seems a little odd to allow customization of the http port but not the https port. Maybe add that one in as well?

ranum commented 2 years ago

Our use case only requires the forwarding for the http endpoint. Didn't want to go any further at this point.

lmsurpre commented 2 years ago

the update to paths from a list of strings to a list of objects is a breaking change, so I added the breaking label.

I wonder if we should bump to version 0.5.0 for that? @michaelwschroeder @chgl any thoughts on that?

michaelwschroeder commented 2 years ago

the update to paths from a list of strings to a list of objects is a breaking change, so I added the breaking label.

I wonder if we should bump to version 0.5.0 for that? @michaelwschroeder @chgl any thoughts on that?

I think that probably makes sense.

ranum commented 2 years ago

ok, I'll move it to 0.5.0 and rerun the helm-docs