Alvearie / alvearie-helm

repository for the helm chart source and package for Alvearie projects
https://artifacthub.io/packages/helm/linuxforhealth
Apache License 2.0
3 stars 5 forks source link

Schematool fails with `=` in PostgreSQL password #84

Open bauerjs1 opened 1 year ago

bauerjs1 commented 1 year ago

While I was spinning up a new deployment of the FHIR server, the schematool did not run properly, because of an = character in the database password.

java.lang.IllegalArgumentException: Property must be defined as key=value, not: password=abcdefgh0123=567
    at com.ibm.fhir.schema.app.Main.addProperty(Main.java:2196)
    at com.ibm.fhir.schema.app.Main.parseArgs(Main.java:2011)
    at com.ibm.fhir.schema.app.Main.main(Main.java:2790)

As you can see, this also makes the schematool print the password in clear text to the logs.

We create our databases via a Kubernetes Postgres Operator, which creates random password strings. I changed that user's password afterwards by replacing the = with a - which solves the issue.

I am not sure, if quoting the values on the command line would solve this – if not, this is probably a bug in the schema conversion tool itself (rather than in the Helm chart), isn't it?

Cheers, Johannes